Add CD rollback + non-root Dockerfile examples#15
Merged
Conversation
- cd.yml: capture previous running image before deploy; on --wait failure, rewrite compose with previous tag and restart - DOCKERFILE_EXAMPLES.md: add non-root user (USER app) to Python, Go, Rust, Java examples to match the Node example's USER node pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two hardening improvements for the deploy pipeline and example Dockerfiles.
CD rollback (
.github/workflows/cd.yml)docker compose up -d --waitfails the health check, rewrites the compose file with the previous tag and restarts.Non-root USER in examples (
docs/DOCKERFILE_EXAMPLES.md)USER appdirective to the Python, Go, Rust, and Java examples, matching the existing Node example'sUSER nodepattern.Test plan
cd.yml.